Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hadolint and Trivy Checks #557

Merged
merged 19 commits into from
Aug 3, 2023
Merged

Add Hadolint and Trivy Checks #557

merged 19 commits into from
Aug 3, 2023

Conversation

samuelarogbonlo
Copy link
Contributor

No description provided.

Copy link
Member

@sea212 sea212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a fast scan-over opinion, proper review coming soon.

The major thing I see is that we do the checks when we want to publish the docker images. I assume an lint/security issue will stop the publishing of the image, won't it?
I think it would be better to check those before a PR is merged into main. In regards to that, it would be nice to triggers those checks only when relevant changes are made.

@sea212 sea212 added the s:review-needed The pull request requires reviews label Apr 15, 2022
@samuelarogbonlo
Copy link
Contributor Author

Hello @sea212 can you please take a look at the changes I've made so far? And possibly take a look at the results of the job in https://github.com/zeitgeistpm/zeitgeist/actions/runs/4145477882/jobs/7169887429

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2023

This pull request is now in conflicts. Could you fix it @samuelarogbonlo? 🙏

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #557 (a48763a) into main (bac24e6) will increase coverage by 0.00%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   92.93%   92.94%           
=======================================
  Files          92       92           
  Lines       21589    21581    -8     
=======================================
- Hits        20064    20058    -6     
+ Misses       1525     1523    -2     
Flag Coverage Δ
tests 92.94% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2023

This pull request is now in conflicts. Could you fix it @samuelarogbonlo? 🙏

@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2023

This pull request is now in conflicts. Could you fix it @samuelarogbonlo? 🙏

@mergify mergify bot added s:revision-needed The pull requests must be revised and removed s:review-needed The pull request requires reviews labels Jul 20, 2023
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:revision-needed The pull requests must be revised labels Jul 27, 2023
@sea212 sea212 added s:accepted This pull request is ready for merge s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews s:accepted This pull request is ready for merge labels Aug 3, 2023
.github/workflows/docker-hub.yml Outdated Show resolved Hide resolved
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Aug 3, 2023
@sea212 sea212 added this to the v0.3.11 milestone Aug 3, 2023
@sea212 sea212 merged commit 82ead37 into main Aug 3, 2023
10 checks passed
@sea212 sea212 deleted the samuel/cicd branch August 3, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants