Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max_encoded_len() for MarketPeriod and MarketType. #703

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Fix max_encoded_len() for MarketPeriod and MarketType. #703

merged 1 commit into from
Jul 11, 2022

Conversation

vivekvpandya
Copy link
Contributor

sea212
sea212 approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@sea212 sea212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vivek! Great to see tests that verify the max length, good job.

@sea212 sea212 added this to the v0.3.5 milestone Jul 8, 2022
@sea212 sea212 added the s:review-needed The pull request requires reviews label Jul 8, 2022
maltekliemann
maltekliemann approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@maltekliemann maltekliemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic idea to add tests for this! 👍

If you want to, you could go even further and check that for market type Categorical, the len is less than max_encoded_len(). But we can keep that for a future PR.

@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Jul 8, 2022
Chralt98
Chralt98 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@Chralt98 Chralt98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivekvpandya vivekvpandya merged commit a98281e into main Jul 11, 2022
@vivekvpandya vivekvpandya deleted the audit1-40 branch July 19, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea212 sea212 sea212 approved these changes

@Chralt98 Chralt98 Chralt98 approved these changes

@maltekliemann maltekliemann maltekliemann approved these changes

Assignees

@vivekvpandya vivekvpandya

Labels
s:accepted This pull request is ready for merge
Projects
None yet
Milestone
v0.3.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vivekvpandya @sea212 @Chralt98 @maltekliemann