New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade codebase to polkadot-v0.9.23 #811
Conversation
Also uses VrfKeys as second key in author mapping. The author_rotateKeys rpc will respect that. Transactions that include filtered calls will not make it into the tx pool anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of formatting nitpicks, which I think should be fixed, but if you want to skip another CI cycle, I think we're good to go on this one. 👍
parity-scale-codec = { default-features = false, features = [ | ||
"derive", | ||
"max-encoded-len", | ||
], version = "3.0.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parity-scale-codec = { default-features = false, features = [ | |
"derive", | |
"max-encoded-len", | |
], version = "3.0.0" } | |
parity-scale-codec = { default-features = false, features = ["derive", "max-encoded-len"], version = "3.0.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3e31ec2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closes #809
Closes #715
This PR updates the dependencies.
Additional features
get_spot_price
and corresponding RPCsauthor_rotateKeys
rpc and topallet-author-mapping
jsonrpsee
instead ofjsonrpc_core
try-runtime
work forpallet-author-mapping
Notes
Executing
try-runtime
will show decoding errors forpallet-author-mapping
. This happens afterpre_upgrade
andon_runtime_upgrade
and can be ignored - the storage is correctly migrated, as thetry-runtime
checks prove. In addition, the runtime upgrade was tested on a Battery Station clone. Unfortunately nodes have to upgrade their clients to be able to determine the author of the first block after the runtime upgrade.