Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codebase to polkadot-v0.9.23 #811

Merged
merged 37 commits into from Oct 18, 2022
Merged

Upgrade codebase to polkadot-v0.9.23 #811

merged 37 commits into from Oct 18, 2022

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Sep 28, 2022

Closes #809
Closes #715

This PR updates the dependencies.

Additional features

  • Use original repositories instead of forks (previously many forks from Moonbeam were used)
  • Use references in get_spot_price and corresponding RPCs
  • Implement Moonbeam's VRFs (generate randomness) in the client, add it to author_rotateKeys rpc and to pallet-author-mapping
  • Build benchmarks from parachain modules only when parachain modules are activated by another feature
  • Use jsonrpsee instead of jsonrpc_core
  • Use patched Purestake libraries to ensure all modules are fetched from original repositories and make try-runtime work for pallet-author-mapping

Notes
Executing try-runtime will show decoding errors for pallet-author-mapping. This happens after pre_upgrade and on_runtime_upgrade and can be ignored - the storage is correctly migrated, as the try-runtime checks prove. In addition, the runtime upgrade was tested on a Battery Station clone. Unfortunately nodes have to upgrade their clients to be able to determine the author of the first block after the runtime upgrade.

@sea212 sea212 added the s:in-progress The pull requests is currently being worked on label Sep 28, 2022
@sea212 sea212 added this to the v0.3.6 milestone Sep 28, 2022
@sea212 sea212 self-assigned this Sep 28, 2022
@sea212 sea212 marked this pull request as draft September 28, 2022 20:56
@sea212 sea212 marked this pull request as ready for review October 7, 2022 14:54
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Oct 7, 2022
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Oct 18, 2022
@sea212 sea212 added s:in-progress The pull requests is currently being worked on s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews s:in-progress The pull requests is currently being worked on labels Oct 18, 2022
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Oct 18, 2022
primitives/Cargo.toml Outdated Show resolved Hide resolved
vivekvpandya
vivekvpandya previously approved these changes Oct 18, 2022
vivekvpandya
vivekvpandya previously approved these changes Oct 18, 2022
maltekliemann
maltekliemann previously approved these changes Oct 18, 2022
Copy link
Member

@maltekliemann maltekliemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of formatting nitpicks, which I think should be fixed, but if you want to skip another CI cycle, I think we're good to go on this one. 👍

runtime/common/src/lib.rs Outdated Show resolved Hide resolved
zrml/prediction-markets/fuzz/Cargo.toml Outdated Show resolved Hide resolved
Comment on lines +2 to +5
parity-scale-codec = { default-features = false, features = [
"derive",
"max-encoded-len",
], version = "3.0.0" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
parity-scale-codec = { default-features = false, features = [
"derive",
"max-encoded-len",
], version = "3.0.0" }
parity-scale-codec = { default-features = false, features = ["derive", "max-encoded-len"], version = "3.0.0" }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@maltekliemann maltekliemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Oct 18, 2022
@sea212 sea212 merged commit 5033991 into main Oct 18, 2022
@sea212 sea212 deleted the sea212-upgrade-codebase branch October 18, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
3 participants