Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of pallet_multisig #965

Merged
merged 2 commits into from Feb 6, 2023
Merged

Fix name of pallet_multisig #965

merged 2 commits into from Feb 6, 2023

Conversation

maltekliemann
Copy link
Member

Unfortunately, it's currently not possible to use multisigs via polkadot-js (see the screenshot below).

Screenshot 2023-02-03 at 23 27 36

The problem is solved by renaming the identifier of pallet_multisig from MultiSig to Multisig.

@maltekliemann maltekliemann self-assigned this Feb 3, 2023
@maltekliemann maltekliemann added the s:review-needed The pull request requires reviews label Feb 3, 2023
@maltekliemann maltekliemann added this to the v0.3.9 milestone Feb 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #965 (fb2d260) into main (45edad6) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #965   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          93       93           
  Lines       21060    21060           
=======================================
  Hits        19880    19880           
  Misses       1180     1180           
Flag Coverage Δ
tests 94.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@sea212 sea212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good discovery. Interesting. The technical committee page works the same way, it requires a specific name in the runtime. Wondering if other pallets are still affected by this.

@sea212 sea212 requested a review from Chralt98 February 4, 2023 08:16
@Chralt98 Chralt98 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Feb 6, 2023
@maltekliemann maltekliemann merged commit 941a675 into main Feb 6, 2023
@maltekliemann maltekliemann deleted the mkl-fix-multisig branch February 6, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants