Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify to follow the rules of the new 'standard' #27

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Sep 7, 2018

I upgraded the package and
fixed it according to the latest 'standard' rules.

@abetomo
Copy link
Contributor Author

abetomo commented Sep 7, 2018

The test fails in End-of-Life Node.js.
I opened a PR (#26) to update travis.yml.

@zeke
Copy link
Owner

zeke commented Sep 7, 2018

Hey I've merged your other PRs. If you rebase this branch with master, it may fix the failing CI here.

Thanks for the updates!

I upgraded the package and
fixed it according to the latest 'standard' rules.
@abetomo
Copy link
Contributor Author

abetomo commented Sep 7, 2018

@zeke Thank you for review!
I rebased.

@zeke zeke merged commit 8023aa4 into zeke:master Sep 12, 2018
@zeke
Copy link
Owner

zeke commented Sep 12, 2018

$ np major
 ✔ Prerequisite check
 ✔ Git
 ✔ Cleanup
 ✔ Installing dependencies using npm
 ✔ Running tests
 ✔ Bumping version using npm
 ✔ Publishing package
 ✔ Pushing tags

 standard-markdown 5.0.0 published 🎉

@zeke
Copy link
Owner

zeke commented Sep 12, 2018

Thanks, @abetomo 🤘

@abetomo abetomo deleted the upgrade_packages branch September 13, 2018 01:01
@abetomo
Copy link
Contributor Author

abetomo commented Sep 13, 2018

Thank you for release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants