Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auto voicechannel feature #357

Merged
merged 21 commits into from
Feb 22, 2022
Merged

add auto voicechannel feature #357

merged 21 commits into from
Feb 22, 2022

Conversation

TomRomeo
Copy link
Contributor

Hello! I really like this bot and wanted to contribute a feature. 😊
When I was checking out the discussions for possible features to implement, I came across the auto voicechannel feature.


Short description of the feature:

Some voicechannels can be set as 'auto voicechannels'.
When a member joins this channel, a custom voicechannel will be created for them.
When they leave this channel, it gets removed again.


For this feature I have implemented the following commands:

  • autovc add #voicechannel
  • autovc remove #voicechannel
  • autovc purge
  • autovc show

and the following permissions:

  • sp.guild.config.autochannel
  • sp.chat.autochannel

The current behavior is the following:

  • When someone joins an auto voicechannel, they get moved to a channel named after themselves.
  • When they move or leave out of that channel, it gets deleted again.
  • When they join the auto voicechannel from their custom vc, the custom vc gets removed but no new one is created.

Some things that might be nice to add:

  • A possibility to rename the custom vcs might be nice? Or a prefix for custom vcs
  • Some commands to lock the channel to a number of members or to add a whitelist might be nice
  • Right now, the channels would not get removed when the bot goes offline, that is probably no great

Let me know what you think! 👋

@zekroTJA
Copy link
Owner

Man, that looks awesome. Thank you very much for the contribution! 😍

I will test around a bit with your implementation later today, but looks very good as what I've seen already.

Copy link
Owner

@zekroTJA zekroTJA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some things that might need a change, if you don't mind. ^^

If you have any questions or need some help for something, feel absolutely free to contact me on my Discord (zekro#0001) or Twitter or simply via mail. :)

internal/commands/cmdautovc.go Show resolved Hide resolved
internal/listeners/autovc.go Outdated Show resolved Hide resolved
internal/listeners/autovc.go Show resolved Hide resolved
@TomRomeo
Copy link
Contributor Author

Hey! Thanks for the thorough review! 😄I will be working on your suggestions!

@zekroTJA zekroTJA changed the base branch from master to dev February 22, 2022 10:55
@zekroTJA zekroTJA merged commit 19cb9d2 into zekroTJA:dev Feb 22, 2022
@zekroTJA
Copy link
Owner

Looks very goo.d Thank you for your awesome contribution. ^^

zekroTJA added a commit that referenced this pull request Mar 3, 2022
When an auto voice channel is deleted, also remove the entry from the database.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants