-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: Add clean_builtsrc
, clean_builtassets
#1444
Closed
Dragorn421
wants to merge
4
commits into
zeldaret:main
from
Dragorn421:meta_makefile_more_clean_options
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -251,6 +251,14 @@ endif | |||||
clean: | ||||||
$(RM) -r $(ROM) $(ELF) build | ||||||
|
||||||
clean_builtsrc: | ||||||
$(RM) -r $(ROM) $(ELF) build/src build/data | ||||||
find build -maxdepth 1 -type f -exec rm {} \; | ||||||
|
||||||
clean_builtassets: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Wonder if this would be better to mirror |
||||||
$(RM) -r $(ROM) $(ELF) build/assets | ||||||
find build -maxdepth 1 -type f -exec rm {} \; | ||||||
|
||||||
assetclean: | ||||||
$(RM) -r $(ASSET_BIN_DIRS) | ||||||
$(RM) -r assets/text/*.h | ||||||
|
@@ -271,7 +279,7 @@ test: $(ROM) | |||||
$(EMULATOR) $(EMU_FLAGS) $< | ||||||
|
||||||
|
||||||
.PHONY: all clean setup test distclean assetclean | ||||||
.PHONY: all clean clean_builtsrc clean_builtassets setup test distclean assetclean | ||||||
|
||||||
#### Various Recipes #### | ||||||
|
||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this
find
doing exactly?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's removing files directly inside
build/
, i.e.dmadata_table_spec.h ldscript.txt spec undefined_syms.txt z64.map
(inbuild/
)I could also put that list of files into the makefile tbh but it felt less random to remove all files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(fwiw this is not advanced find usage at all, assuming this may get in and if we keep it I'll add a comment on it though)