Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.10.15-zen1 fails to cold boot on Ryzen 7 system. #201

Closed
texstar opened this issue Feb 12, 2021 · 4 comments
Closed

5.10.15-zen1 fails to cold boot on Ryzen 7 system. #201

texstar opened this issue Feb 12, 2021 · 4 comments

Comments

@texstar
Copy link

texstar commented Feb 12, 2021

Grub locks up after selecting 5.10.15-zen1 from a cold boot. Pressing the reset button then it works or rebooting from another kernel also works. Not sure what is going on with being able to boot it after turning on the computer.
@heftig
Copy link

heftig commented Feb 12, 2021

Assuming you're running Arch Linux, is 5.10.15-arch1 affected as well?

@texstar
Copy link
Author

texstar commented Feb 12, 2021 •
edited
Loading

No. I built it on PCLInuxOS 2021. Also a user with a Ryzen 3 laptop had the same issue. It cold boots OK on my Intel Chromebook converted Square. Kernel built from kernel.org sources are also OK.

@Atemu
Copy link

Atemu commented Feb 12, 2021

5.10.15-zen1 boots on my Ryzen 5 3600 + B550 combo.

(AMDGPU is broken though, see #200)

Does 5.10.14-lqx2 boot on your machine @texstar? It exhibits the same AMDGPU issue on mine, so it might be the same root cause.

@texstar
Copy link
Author

texstar commented Feb 12, 2021

Ok, thanks for the feedback Atemu. I simply dropped the zen-source tarball in as a replacement for official kernel sources to build our rpm packages as a test. Apparently there must be a conflict within our patchset and the zen-source tarball. Please disregard this bug report.

@damentz damentz closed this as completed Feb 14, 2021
damentz pushed a commit that referenced this issue Jun 14, 2023
@yonghong-song @gregkh
selftests/bpf: Fix sockopt_sk selftest
235325b 
[ Upstream commit 69844e3 ]

Commit f4e4534 ("net/netlink: fix NETLINK_LIST_MEMBERSHIPS length report")
fixed NETLINK_LIST_MEMBERSHIPS length report which caused
selftest sockopt_sk failure. The failure log looks like

  test_sockopt_sk:PASS:join_cgroup /sockopt_sk 0 nsec
  run_test:PASS:skel_load 0 nsec
  run_test:PASS:setsockopt_link 0 nsec
  run_test:PASS:getsockopt_link 0 nsec
  getsetsockopt:FAIL:Unexpected NETLINK_LIST_MEMBERSHIPS value unexpected Unexpected NETLINK_LIST_MEMBERSHIPS value: actual 8 != expected 4
  run_test:PASS:getsetsockopt 0 nsec
  #201     sockopt_sk:FAIL

In net/netlink/af_netlink.c, function netlink_getsockopt(), for NETLINK_LIST_MEMBERSHIPS,
nlk->ngroups equals to 36. Before Commit f4e4534, the optlen is calculated as
  ALIGN(nlk->ngroups / 8, sizeof(u32)) = 4
After that commit, the optlen is
  ALIGN(BITS_TO_BYTES(nlk->ngroups), sizeof(u32)) = 8

Fix the test by setting the expected optlen to be 8.

Fixes: f4e4534 ("net/netlink: fix NETLINK_LIST_MEMBERSHIPS length report")
Signed-off-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20230606172202.1606249-1-yhs@fb.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@heftig @damentz @texstar @Atemu