Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Atomic Bomb module #328

Merged
merged 6 commits into from Jun 2, 2020
Merged

Add Atomic Bomb module #328

merged 6 commits into from Jun 2, 2020

Conversation

mharis001
Copy link
Member

When merged this pull request will:

@mharis001 mharis001 added the feature Adds a new feature label Mar 18, 2020
@mharis001 mharis001 added this to the 1.7.1 milestone Mar 18, 2020
CreepPork
CreepPork approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine code-wise but it is a bit difficult to read.

@mharis001 mharis001 modified the milestones: 1.7.1, 1.8.0 Mar 25, 2020
@mharis001 mharis001 requested a review from neilzar May 28, 2020 22:01
@mharis001 mharis001 merged commit 86fc60e into master Jun 2, 2020
@mharis001 mharis001 deleted the nuke-module branch June 2, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CreepPork CreepPork CreepPork approved these changes

@neilzar neilzar neilzar approved these changes

Assignees
No one assigned
Labels
feature Adds a new feature
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Feature Request: New options in the Fire Support section
3 participants
@mharis001 @CreepPork @neilzar