Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework and improve dialog component #374

Merged
merged 2 commits into from May 27, 2020
Merged

Rework and improve dialog component #374

merged 2 commits into from May 27, 2020

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • Make various improvements to the dialog component
  • Refactor how content controls return their values
    • Rather keep track of the value as changes are made, controls define a QFUNC(value) function that returns their current value
    • Simplifies a lot of the control specific functions since a lot less handling is needed
  • Use common base UI classes and display for the dialog
    • Fix scrollbar overlap with content controls when the content height is greater than the maximum
  • Add _saveID parameter to create function specify a custom save ID
    • Needed when, for example, the title may change between dialog multiple openings of the dialog but the content remains the same
  • Add _args parameter to initSliderEdit common function
  • Fix initDisplayPositioning common function not setting the content's height when it is greater than the maximum
  • Fix issue where the saved value was modified even though the dialog was cancelled for COLOR, OWNERS, and VECTOR control types
    • Saved value array was being modified by reference

Control specific changes:

  • COLOR
    • Changed the color preview to be bigger
    • Changed to use common initSliderEdit for the UI handling
  • COMBO / LIST
    • Added option to sort entries alphabetically
    • LIST now uses COMBO's function since handling is identical other than setting the list height
  • OWNERS
  • SIDES
    • Changed to use common sides control
    • Added ability to have multi-select sides controls, specified by an array of sides as the default value
  • SLIDER
    • Changed to use common initSliderEdit for the UI handling

@mharis001 mharis001 added the enhancement Improves an existing feature label May 11, 2020
@mharis001 mharis001 added this to the 1.8.0 milestone May 11, 2020
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any documentation changes?

@mharis001
Copy link
Member Author

Will update documentation in another PR.

@mharis001 mharis001 merged commit b6422ff into master May 27, 2020
@mharis001 mharis001 deleted the dialog-rework branch May 27, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select all / deselect all options for the Teleporter module
3 participants