Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use configOf instead of typeOf config lookup #482

Merged
merged 3 commits into from Oct 15, 2020
Merged

use configOf instead of typeOf config lookup #482

merged 3 commits into from Oct 15, 2020

Conversation

neilzar
Copy link
Contributor

@neilzar neilzar commented Oct 15, 2020

When merged this pull request will:

  • Use configOf that was introduced in 2.00, it is twice as fast as using typeOf in a config lookup.

@mharis001
Copy link
Member

Should also bump REQUIRED_VERSION.

@mharis001 mharis001 added the optimization Makes performance improvements label Oct 15, 2020
@mharis001 mharis001 added this to the 1.10.0 milestone Oct 15, 2020
@neilzar neilzar merged commit 051a953 into master Oct 15, 2020
@mharis001 mharis001 deleted the dev-branch-changes branch October 15, 2020 21:41
@shukari shukari mentioned this pull request Oct 16, 2020
Open
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CreepPork CreepPork CreepPork approved these changes

@mharis001 mharis001 mharis001 approved these changes

Assignees
No one assigned
Labels
optimization Makes performance improvements
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neilzar @mharis001 @CreepPork