Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faction Filter #504

Merged
merged 3 commits into from Jan 14, 2021
Merged

Add Faction Filter #504

merged 3 commits into from Jan 14, 2021

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • Add faction_filter component
  • Fix invisible side buttons on initial load with empty trees
    • Simplify code for modeChanged and sideChanged events

Works well when tested with popular asset mods. Deals with the following object categorization trickiness (for Zeus):

  • side of CfgFactionClasses doesn't determine under which side an object is sorted.
  • editorCategory can also be used to categorize an object (although generally not used for characters and vehicles).
  • group compositions can have a different faction display name than objects from the same faction.

As a result, we don't use CfgFactionClasses directly and instead scan CfgPatches units arrays and CfgGroups to find factions.

@mharis001 mharis001 added the feature Adds a new feature label Jan 12, 2021
@mharis001 mharis001 added this to the 1.10.0 milestone Jan 12, 2021
@Kexanone
Copy link
Member

Seems to work well in "vanilla", but we might want to check some more mods.
Going back to my other question: #387 (comment)

Copy link
Contributor

@neilzar neilzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to work with all RHS mods and 3CB factions, so I'd say all mods should work.

@Kexanone Kexanone merged commit 34d103b into master Jan 14, 2021
@Kexanone Kexanone deleted the faction-filter branch January 14, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Module & Faction Curator Restrictions
3 participants