Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Area Markers - Improve edit box handling #587

Merged
merged 2 commits into from Apr 30, 2021
Merged

Area Markers - Improve edit box handling #587

merged 2 commits into from Apr 30, 2021

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • Properly handle deleting characters - account for cursor position and allow for selections to be deleted
  • Add support for selecting all characters using CTRL + A
  • Use focusedCtrl to check if an edit box is focused instead of control focus events

@mharis001 mharis001 added the enhancement Improves an existing feature label Apr 28, 2021
@mharis001 mharis001 added this to the 1.11.0 milestone Apr 28, 2021
@CreepPork CreepPork mentioned this pull request Apr 29, 2021
Merged
@mharis001 mharis001 merged commit c5f3db4 into master Apr 30, 2021
@mharis001 mharis001 deleted the area-markers-edit-boxes branch April 30, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CreepPork CreepPork CreepPork approved these changes

@neilzar neilzar neilzar approved these changes

Assignees
No one assigned
Labels
enhancement Improves an existing feature
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mharis001 @CreepPork @neilzar