Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to rotate placement preview objects #703

Merged
merged 2 commits into from Jan 22, 2023

Conversation

ampersand38
Copy link
Member

When merged this pull request will:

  • Enable rotation of placement preview when holding Zeus rotation modifier, default L Shift
  • Preview rotation is preserved if Shift is released
  • Object can be placed while Shift is held down
  • Object rotation matches preview

@mharis001
Copy link
Member

Has weird handling when the mouse world position is "past" the object's position (see images).

Images

Placement preview (cursor is below the object in both cases as seen by the icon here):

image

Normal Zeus rotation:

image

@mharis001 mharis001 added the enhancement Improves an existing feature label Jan 21, 2023
@mharis001 mharis001 added this to the 1.13.0 milestone Jan 21, 2023
@mharis001 mharis001 changed the title Placement - rotation Add ability to rotate placement preview objects Jan 21, 2023
@mharis001
Copy link
Member

I pushed a simple change that should improve the behaviour and cover all cases. Could use a second look.

@ampersand38
Copy link
Member Author

I pushed a simple change that should improve the behaviour and cover all cases. Could use a second look.

You've managed to copy the vanilla zeus rotation behaviour xD I had always wondered why it didn't point directly to the cursor, but felt a little off. It's working from 2D screenpos!

@ampersand38 ampersand38 merged commit a69045c into zen-mod:master Jan 22, 2023
@ampersand38 ampersand38 deleted the placement-rotation branch January 22, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants