Feature menu bar application implementation #123
Conversation
- Add menu bar controller for adding menu bar items to the new application icon that appears in the system menu bar - Refactor AppDelegate to clean up some of the setup code - Move main window setup to `FeatureFactory` - Rename `MainWindow` implementation to `Window` in order to reuse the implementation later on - Add new icons for active and inactive menu bar item
| return (applicationProvider: applicationProvider, | ||
| commandFeature: commandsController, | ||
| groupsFeature: groupFeatureController, | ||
| keyboardFeature: keyboardFeatureController, | ||
| searchFeature: searchFeatureController, | ||
| workflowFeature: workflowFeatureController) |
There was a problem hiding this comment.
I don't think you need to name the values when returning, as the return value already does that. Makes it a bit less verbose at least 🤷
(applicationProvider,
commandsController,
groupFeatureController,
keyboardFeatureController,
searchFeatureController,
workflowFeatureController)There was a problem hiding this comment.
I added labels in order to make it easier to work with.
If you look at how it's used in AppDelegate, it looks like this:
context.groupsFeature.delegate = selfIf we omit the labels, it would either end up being .0 (depending on the index from the tuple) or having to assign variables like let (_, groupsFeature, _, _, _) = …
There was a problem hiding this comment.
Yeah, the labels should not be omitted on the return type, but when returning the tuple, I'm fairly certain we don't need to actually label them, they will be labelled automagically! (But I might be wrong)
| @@ -3,6 +3,13 @@ import LogicFramework | |||
| import ViewKit | |||
| import ModelKit | |||
|
|
|||
| typealias ApplicationStackContext = (applicationProvider: ApplicationsProvider, | |||
There was a problem hiding this comment.
If this type alias is not used anywhere else than in feature factory, I say let's move inside that class
- Make class `final` - Remove `ApplicationStackContext` typealias - Add `applications` to `GroupsFeatureController.init` - Make `MenubarController` final
application icon that appears in the system menu bar
FeatureFactoryMainWindowimplementation toWindowin order to reuse theimplementation later on
Screenshot