Improve handling mouse clicks on macOS #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation is redundant as we add a target and action inside `Component`. `NSTableView` inherits from `NSControl` which supports this kind of behavior.
I ended up mocking `clickedRow` on `NSTableView` to be able to test the click behavior. I tried a bunch of other approaches before, like triggering actions on the view that should be clicked but that does not trigger anything in the responder chain, `clickedRow` remained unchanged.
|
@zenangst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @JohnSundell to be a potential reviewer. |
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 82.78% 83.01% +0.23%
==========================================
Files 120 121 +1
Lines 9051 9104 +53
==========================================
+ Hits 7493 7558 +65
+ Misses 1558 1546 -12
Continue to review full report at Codecov.
|
This is done to avoid recursion, if we don't force unwrap here it will end up running the same function over and over again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
mouseClickproperty onInteraction. Now you can easily configure if you should single or double click onNSTableView-based components. Will try to add the same behavior toNSCollectionViewbased views in the future.mouseClickdoes not really make sense to include on any other platform thanmacOS.So I'll make an issue to make two
Interactionstructs, one for click-based OS:es and one combined foriOSandtvOS. I didn't include that change in this PR to keep the size down.