Implement makeView on Registry #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`makeView(from item: Item, with frame: CGRect)` can be used to create views based of an `Item`. This is useful when you need to make a copy of a view that should not be bound by the reusability boundaries of Spots internal mechanisms.
|
@zenangst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @onmyway133 and @JohnSundell to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
==========================================
+ Coverage 87.74% 87.74% +<.01%
==========================================
Files 128 129 +1
Lines 10452 10472 +20
==========================================
+ Hits 9171 9189 +18
- Misses 1281 1283 +2
Continue to review full report at Codecov.
|
vadymmarkov
approved these changes
Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeView(from item: Item, with frame: CGRect)can be used to create views based of anItem. This is useful when you need to make a copy of a view that should not be bound by the reusability boundaries of Spots internal mechanisms.