Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Warning: Undefined variable $extra_headings in tpl_account_history_info_default.php (strict reporting) #6058

Closed
torvista opened this issue Nov 20, 2023 · 1 comment · Fixed by #6060

Comments

@torvista
Copy link
Member

php 8.3.0RC6, Windows local server, strict_reporting

Buy a product, get a debug:

[20-Nov-2023 16:17:58 UTC] Request URI: /zencart/index.php?main_page=checkout_success, IP address: 127.0.0.1, Language id 1
#0 D:\GitHub\zencart\includes\templates\template_default\templates\tpl_account_history_info_default.php(39): zen_debug_error_handler()
#1 D:\GitHub\zencart\includes\templates\template_default\templates\tpl_checkout_success_default.php(73): require('D:\GitHub\zenca...')
#2 D:\GitHub\zencart\includes\templates\responsive_classic\common\tpl_main_page.php(178): require('D:\GitHub\zenca...')
#3 D:\GitHub\zencart\index.php(94): require('D:\GitHub\zenca...')
--> PHP Warning: Undefined variable $extra_headings in D:\GitHub\zencart\includes\templates\template_default\templates\tpl_account_history_info_default.php on line 39.

Due to the initialisation and subsequent use of $extra_headings being in different clauses:
https://github.com/zencart/zencart/pull/6051/files

@neekfenwick
Copy link
Contributor

Looks like my fault. I'll move the initialisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants