fix test directory constants #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nother poorly configured SSL proxy used by various hosting companies
… duplication in COWOA code
…email - to make for easier replying to customers
…SSL: the language icons were being accessed as non-secure resources.
…om being spidered/indexed
…rs\ to match pattern of indicating which folders support overrides
…x infrastructure) (added error checking, so that other ajax scripts don't trigger language-file-not-found errors caused by the last commit to this file)
…ccasional case where site operates entirely in SSL
…fit on smaller screens
…r customized/external handling of taxes
…ues throwing PHP Warning: strlen() expects parameter 1 to be string Also required adding 'notify' as an excluded GET element in a few places.
…ues throwing PHP Warning: strlen() expects parameter 1 to be string
This was referenced Jul 27, 2023
lat9
added a commit
that referenced
this pull request
Oct 7, 2023
If a customer's not logged in, getting a PHP warning: ``` [07-Oct-2023 13:15:31 America/New_York] Request URI: /zc200/, IP address: 127.0.0.1, Language id 1 #0 C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php(11): zen_debug_error_handler() #1 C:\xampp\htdocs\zc200\includes\modules\column_right.php(30): include('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\zc200\includes\templates\bootstrap\common\tpl_main_page.php(251): require('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200\index.php(94): require('C:\\xampp\\htdocs...') --> PHP Warning: Undefined array key "customer_id" in C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php on line 11. [07-Oct-2023 13:15:31 America/New_York] PHP Fatal error: Uncaught TypeError: zen_user_has_gv_account(): Argument #1 ($customer_id) must be of type int, null given, called in C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php on line 11 and defined in C:\xampp\htdocs\zc200\includes\functions\functions_gvcoupons.php:54 Stack trace: #0 C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php(11): zen_user_has_gv_account(NULL) #1 C:\xampp\htdocs\zc200\includes\modules\column_right.php(30): include('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\zc200\includes\templates\bootstrap\common\tpl_main_page.php(251): require('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200\index.php(94): require('C:\\xampp\\htdocs...') #4 {main} thrown in C:\xampp\htdocs\zc200\includes\functions\functions_gvcoupons.php on line 54 ```
This was referenced Oct 11, 2023
Merged
drbyte
pushed a commit
that referenced
this pull request
Oct 25, 2023
... for PHP 8.2 and later. Seeing logs like ``` [15-Oct-2023 08:38:27 America/New_York] PHP Fatal error: Uncaught TypeError: mktime(): Argument #4 ($month) must be of type ?int, string given in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php:23 Stack trace: #0 C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php(23): mktime(0, 0, 0, 'my', 'tt', '`php') #1 C:\xampp\htdocs\zc200\admin200\index_dashboard.php(65): include('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\zc200\admin200\home.php(25): require('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200\admin200\index.php(11): require('C:\\xampp\\htdocs...') #4 {main} thrown in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php on line 23 ```
drbyte
pushed a commit
that referenced
this pull request
Oct 26, 2023
…6022) Seeing logs similar to the following due to variable-name 'misspelling': ``` [25-Oct-2023 11:38:20 America/Chicago] Request URI: /index.php?main_page=checkout_process, IP address: x.x.x.x, Language id 1 #0 /home/mystore/public_html/includes/classes/payment.php(134): zen_debug_error_handler() #1 /home/mystore/public_html/includes/modules/checkout_process.php(84): payment->checkCreditCovered() #2 /home/mystore/public_html/includes/modules/pages/checkout_process/header_php.php(13): require('/home/mystore/...') #3 /home/mystore/public_html/index.php(35): require('/home/mystore/...') --> PHP Deprecated: Creation of dynamic property payment::$selected_method is deprecated in /home/mystore/public_html/includes/classes/payment.php on line 134. ```
drbyte
pushed a commit
that referenced
this pull request
Dec 9, 2023
Seeing logs like ``` [09-Dec-2023 14:40:04 America/New_York] Request URI: /zc200w/admin200/index.php?cmd=orders&page=1&oID=19&action=edit, IP address: 127.0.0.1, Language id not set #0 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): zen_debug_error_handler() #1 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): require() #2 C:\xampp\htdocs\zc200w\includes\autoload_func.php(40): require_once('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200w\admin200\includes\application_top.php(42): require('C:\\xampp\\htdocs...') #4 C:\xampp\htdocs\zc200w\admin200\orders.php(8): require('C:\\xampp\\htdocs...') #5 C:\xampp\htdocs\zc200w\admin200\index.php(11): require('C:\\xampp\\htdocs...') --> PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in C:\xampp\htdocs\zc200w\admin200\includes\functions\html_output.php on line 265. ```
This was referenced Dec 26, 2023
drbyte
pushed a commit
to drbyte/zencart
that referenced
this pull request
Jan 30, 2024
... for PHP 8.2 and later. Seeing logs like ``` [15-Oct-2023 08:38:27 America/New_York] PHP Fatal error: Uncaught TypeError: mktime(): Argument zencart#4 ($month) must be of type ?int, string given in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php:23 Stack trace: #0 C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php(23): mktime(0, 0, 0, 'my', 'tt', '`php') #1 C:\xampp\htdocs\zc200\admin200\index_dashboard.php(65): include('C:\\xampp\\htdocs...') zencart#2 C:\xampp\htdocs\zc200\admin200\home.php(25): require('C:\\xampp\\htdocs...') zencart#3 C:\xampp\htdocs\zc200\admin200\index.php(11): require('C:\\xampp\\htdocs...') zencart#4 {main} thrown in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php on line 23 ```
drbyte
pushed a commit
to drbyte/zencart
that referenced
this pull request
Jan 30, 2024
…encart#6022) Seeing logs similar to the following due to variable-name 'misspelling': ``` [25-Oct-2023 11:38:20 America/Chicago] Request URI: /index.php?main_page=checkout_process, IP address: x.x.x.x, Language id 1 #0 /home/mystore/public_html/includes/classes/payment.php(134): zen_debug_error_handler() #1 /home/mystore/public_html/includes/modules/checkout_process.php(84): payment->checkCreditCovered() zencart#2 /home/mystore/public_html/includes/modules/pages/checkout_process/header_php.php(13): require('/home/mystore/...') zencart#3 /home/mystore/public_html/index.php(35): require('/home/mystore/...') --> PHP Deprecated: Creation of dynamic property payment::$selected_method is deprecated in /home/mystore/public_html/includes/classes/payment.php on line 134. ```
drbyte
pushed a commit
to drbyte/zencart
that referenced
this pull request
Jan 30, 2024
Seeing logs like ``` [09-Dec-2023 14:40:04 America/New_York] Request URI: /zc200w/admin200/index.php?cmd=orders&page=1&oID=19&action=edit, IP address: 127.0.0.1, Language id not set #0 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): zen_debug_error_handler() #1 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): require() zencart#2 C:\xampp\htdocs\zc200w\includes\autoload_func.php(40): require_once('C:\\xampp\\htdocs...') zencart#3 C:\xampp\htdocs\zc200w\admin200\includes\application_top.php(42): require('C:\\xampp\\htdocs...') zencart#4 C:\xampp\htdocs\zc200w\admin200\orders.php(8): require('C:\\xampp\\htdocs...') zencart#5 C:\xampp\htdocs\zc200w\admin200\index.php(11): require('C:\\xampp\\htdocs...') --> PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in C:\xampp\htdocs\zc200w\admin200\includes\functions\html_output.php on line 265. ```
zcwilt
added a commit
to zcwilt/zencart
that referenced
this pull request
Mar 7, 2024
# This is the 1st commit message: cart refactor # This is the commit message zencart#2: using db # This is the commit message zencart#3: initial commit # This is the commit message zencart#4: cart # This is the commit message zencart#5: cart # This is the commit message zencart#6: cart refactoring # This is the commit message zencart#7: refactor cart # This is the commit message zencart#8: more cart work and testing updates # This is the commit message zencart#9: testing # This is the commit message zencart#10: updates
drbyte
pushed a commit
that referenced
this pull request
Mar 24, 2024
Seeing logs like ``` [24-Mar-2024 15:48:37 America/New_York] Request URI: /zc200w/index.php?main_page=checkout_payment, IP address: 127.0.0.1, Language id 1 #0 C:\xampp\htdocs\zc200w\includes\modules\order_total\ot_loworderfee.php(48): zen_debug_error_handler() #1 C:\xampp\htdocs\zc200w\includes\classes\order_total.php(56): ot_loworderfee->__construct() #2 C:\xampp\htdocs\zc200w\includes\modules\pages\checkout_payment\header_php.php(99): order_total->__construct() #3 C:\xampp\htdocs\zc200w\index.php(35): require('C:\\xampp\\htdocs...') --> PHP Deprecated: Creation of dynamic property ot_loworderfee::$enabled is deprecated in C:\xampp\htdocs\zc200w\includes\modules\order_total\ot_loworderfee.php on line 48. ```
This was referenced May 24, 2024
drbyte
pushed a commit
that referenced
this pull request
May 25, 2024
Seeing logs like the following, using the Bootstrap template and demo products
```
[25-May-2024 13:18:41 America/New_York] PHP Fatal error: Uncaught TypeError: zen_get_products_manufacturers_name(): Return value must be of type string, array returned in C:\xampp\htdocs\zc200w\includes\functions\functions_products.php:520
Stack trace:
#0 C:\xampp\htdocs\zc200w\includes\classes\ajax\zcAjaxBootstrapSearch.php(63): zen_get_products_manufacturers_name('43')
#1 C:\xampp\htdocs\zc200w\ajax.php(72): zcAjaxBootstrapSearch->searchProducts()
#2 {main}
thrown in C:\xampp\htdocs\zc200w\includes\functions\functions_products.php on line 520
[25-May-2024 13:18:41 America/New_York] Request URI: /zc200w/ajax.php?act=ajaxBootstrapSearch&method=searchProducts, IP address: 127.0.0.1
--> PHP Fatal error: Uncaught TypeError: zen_get_products_manufacturers_name(): Return value must be of type string, array returned in C:\xampp\htdocs\zc200w\includes\functions\functions_products.php:520
Stack trace:
#0 C:\xampp\htdocs\zc200w\includes\classes\ajax\zcAjaxBootstrapSearch.php(63): zen_get_products_manufacturers_name('43')
#1 C:\xampp\htdocs\zc200w\ajax.php(72): zcAjaxBootstrapSearch->searchProducts()
#2 {main}
thrown in C:\xampp\htdocs\zc200w\includes\functions\functions_products.php on line 520.
[25-May-2024 13:18:41 America/New_York] Request URI: /zc200w/ajax.php?act=ajaxBootstrapSearch&method=searchProducts, IP address: 127.0.0.1
--> PHP Fatal error: Uncaught TypeError: zen_get_products_manufacturers_name(): Return value must be of type string, array returned in C:\xampp\htdocs\zc200w\includes\functions\functions_products.php:520
Stack trace:
#0 C:\xampp\htdocs\zc200w\includes\classes\ajax\zcAjaxBootstrapSearch.php(63): zen_get_products_manufacturers_name('43')
#1 C:\xampp\htdocs\zc200w\ajax.php(72): zcAjaxBootstrapSearch->searchProducts()
#2 {main}
thrown in C:\xampp\htdocs\zc200w\includes\functions\functions_products.php on line 520.
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to run the lone unit test without this minor change. The directory constants were off by a folder.