Spell error #1
Closed
Spell error #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove page from navigation history, and forward user to timeout page, if necessary thanks to lat9
…ed country domain for accessing PayPal services (per PayPal change Q3-2012)
…is the logs foldername
Note. we use test framework stuff using atlassian bamboo. It is possible to setup a local phpunit and selenium server to run these webtests, however this takes a some setting up to achieve. We will be posting info on the forums on how to achieve this.
Remove bundling of paypal/other payment module tests. update paths and version stamping temporarily comment out screeenshot stuff. need a better helper function fix setup of compoundTests broken, becuase of removal of other tests
…PHP 5.4 refinements
Not using absolute path. See http://www.zen-cart.com/showthread.php?200616-password_forgotten-generates-log-file Thanks to lhungil for fix
…l, so as to prevent confusion caused by caching of files which require alteration.
Added test scenario to initially fail test in init_cart_handler.php was only checking FILENAME_PRODUCT_INFO when it needs to test if its the info page for the product type change fixes test scenario
…yCache enabled, such as was added in v1.5.1)
Update admin version of zen_get_all_get_params to carry out the same sanitization of get params as catalog version of zen_get_all_get_params
This was referenced Jul 27, 2023
scottcwilson
pushed a commit
that referenced
this pull request
Sep 11, 2023
Since that value can be `null`, returning a string prevents PHP deprecate issues like ``` --> PHP Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in C:\xampp\htdocs\zc200\admin\includes\modules\collect_info.php on line 419. ```
lat9
added a commit
that referenced
this pull request
Oct 7, 2023
If a customer's not logged in, getting a PHP warning: ``` [07-Oct-2023 13:15:31 America/New_York] Request URI: /zc200/, IP address: 127.0.0.1, Language id 1 #0 C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php(11): zen_debug_error_handler() #1 C:\xampp\htdocs\zc200\includes\modules\column_right.php(30): include('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\zc200\includes\templates\bootstrap\common\tpl_main_page.php(251): require('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200\index.php(94): require('C:\\xampp\\htdocs...') --> PHP Warning: Undefined array key "customer_id" in C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php on line 11. [07-Oct-2023 13:15:31 America/New_York] PHP Fatal error: Uncaught TypeError: zen_user_has_gv_account(): Argument #1 ($customer_id) must be of type int, null given, called in C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php on line 11 and defined in C:\xampp\htdocs\zc200\includes\functions\functions_gvcoupons.php:54 Stack trace: #0 C:\xampp\htdocs\zc200\includes\modules\sideboxes\shopping_cart.php(11): zen_user_has_gv_account(NULL) #1 C:\xampp\htdocs\zc200\includes\modules\column_right.php(30): include('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\zc200\includes\templates\bootstrap\common\tpl_main_page.php(251): require('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200\index.php(94): require('C:\\xampp\\htdocs...') #4 {main} thrown in C:\xampp\htdocs\zc200\includes\functions\functions_gvcoupons.php on line 54 ```
This was referenced Oct 11, 2023
Merged
drbyte
pushed a commit
that referenced
this pull request
Oct 25, 2023
... for PHP 8.2 and later. Seeing logs like ``` [15-Oct-2023 08:38:27 America/New_York] PHP Fatal error: Uncaught TypeError: mktime(): Argument #4 ($month) must be of type ?int, string given in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php:23 Stack trace: #0 C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php(23): mktime(0, 0, 0, 'my', 'tt', '`php') #1 C:\xampp\htdocs\zc200\admin200\index_dashboard.php(65): include('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\zc200\admin200\home.php(25): require('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200\admin200\index.php(11): require('C:\\xampp\\htdocs...') #4 {main} thrown in C:\xampp\htdocs\zc200\admin200\includes\modules\dashboard_widgets\TrafficDashboardWidget.php on line 23 ```
drbyte
pushed a commit
that referenced
this pull request
Oct 26, 2023
…6022) Seeing logs similar to the following due to variable-name 'misspelling': ``` [25-Oct-2023 11:38:20 America/Chicago] Request URI: /index.php?main_page=checkout_process, IP address: x.x.x.x, Language id 1 #0 /home/mystore/public_html/includes/classes/payment.php(134): zen_debug_error_handler() #1 /home/mystore/public_html/includes/modules/checkout_process.php(84): payment->checkCreditCovered() #2 /home/mystore/public_html/includes/modules/pages/checkout_process/header_php.php(13): require('/home/mystore/...') #3 /home/mystore/public_html/index.php(35): require('/home/mystore/...') --> PHP Deprecated: Creation of dynamic property payment::$selected_method is deprecated in /home/mystore/public_html/includes/classes/payment.php on line 134. ```
drbyte
pushed a commit
that referenced
this pull request
Dec 9, 2023
Seeing logs like ``` [09-Dec-2023 14:40:04 America/New_York] Request URI: /zc200w/admin200/index.php?cmd=orders&page=1&oID=19&action=edit, IP address: 127.0.0.1, Language id not set #0 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): zen_debug_error_handler() #1 C:\xampp\htdocs\zc200w\admin200\includes\init_includes\init_general_funcs.php(39): require() #2 C:\xampp\htdocs\zc200w\includes\autoload_func.php(40): require_once('C:\\xampp\\htdocs...') #3 C:\xampp\htdocs\zc200w\admin200\includes\application_top.php(42): require('C:\\xampp\\htdocs...') #4 C:\xampp\htdocs\zc200w\admin200\orders.php(8): require('C:\\xampp\\htdocs...') #5 C:\xampp\htdocs\zc200w\admin200\index.php(11): require('C:\\xampp\\htdocs...') --> PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in C:\xampp\htdocs\zc200w\admin200\includes\functions\html_output.php on line 265. ```
torvista
referenced
this pull request
Dec 26, 2023
Converts a numeric string to int or float depending on whether it is a whole number or not. Basically performs PHP's coercive string conversion to float or int based on its content, to accommodate what strict_types mode cannot do.
This was referenced Jan 22, 2024
Closed
drbyte
pushed a commit
that referenced
this pull request
Mar 24, 2024
Seeing logs like ``` [24-Mar-2024 15:48:37 America/New_York] Request URI: /zc200w/index.php?main_page=checkout_payment, IP address: 127.0.0.1, Language id 1 #0 C:\xampp\htdocs\zc200w\includes\modules\order_total\ot_loworderfee.php(48): zen_debug_error_handler() #1 C:\xampp\htdocs\zc200w\includes\classes\order_total.php(56): ot_loworderfee->__construct() #2 C:\xampp\htdocs\zc200w\includes\modules\pages\checkout_payment\header_php.php(99): order_total->__construct() #3 C:\xampp\htdocs\zc200w\index.php(35): require('C:\\xampp\\htdocs...') --> PHP Deprecated: Creation of dynamic property ot_loworderfee::$enabled is deprecated in C:\xampp\htdocs\zc200w\includes\modules\order_total\ot_loworderfee.php on line 48. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing important, just a small spell error