Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin, Coupon Admin: Undefined array key "cid" #6267

Closed
torvista opened this issue Feb 29, 2024 · 0 comments · Fixed by #6273
Closed

Admin, Coupon Admin: Undefined array key "cid" #6267

torvista opened this issue Feb 29, 2024 · 0 comments · Fixed by #6273
Assignees
@drbyte

Comments

@torvista
Copy link
Member

strict mode, php 8.3, new install

[29-Feb-2024 09:05:42 UTC] Request URI: /zencart/admin/index.php?cmd=coupon_admin, IP address: 127.0.0.1, Language id 1
#0 D:\GitHub\zencart\admin\coupon_admin.php(1185): zen_debug_error_handler()
#1 D:\GitHub\zencart\admin\index.php(11): require('D:\GitHub\zenca...')
--> PHP Warning: Undefined array key "cid" in D:\GitHub\zencart\admin\coupon_admin.php on line 1185.
drbyte added a commit to drbyte/zencart that referenced this issue Feb 29, 2024
@drbyte
Relocate loading of referrer data in coupon listing
e6ebba2 
Loading it inside the loop allows it to relate to the specified coupon correctly, including the loop's fallback to rendering data for the first one in the list.

Fixes zencart#6267
@drbyte drbyte mentioned this issue Feb 29, 2024
Merged
drbyte added a commit that referenced this issue Mar 1, 2024
@drbyte
Relocate loading of referrer data in coupon listing (#6273)
9f1976e 
Loading it inside the loop allows it to relate to the specified coupon correctly, including the loop's fallback to rendering data for the first one in the list.

Fixes #6267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drbyte drbyte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relocate loading of referrer data in coupon listing drbyte/zencart
2 participants
@drbyte @torvista