-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tax calculation error when Basis of product tax is set to store and Display prices with tax is on. #6384
Comments
Looking at this, I found something crazy... |
Revert prices had nothing to do with this issue. |
Hmmm ... I'd forgotten the "only if client is in same zone" part: I don't know why it got coded that way. I "thought" that "Tax Basis: Store" meant: "use the Store's zone, regardless of customer/billing/shipping address/zone". |
If using tax-included pricing, I can see how it's possible there may be a bug there, which might be related to incorrectly picking the applicable zone to use for adding tax back into the prices for display (again, because tax is never stored "in" the product price: it is always recalculated to add onto the base product price). It really depends on what tax zone is selected for adding the tax back onto the price. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Actually, me too, but looking at the code it is different. |
In last GitHub version, with 'Basis of product tax' set to 'Store' and 'Display Prices with Tax' is set to 'true', and if store zone has not tax rate set.
When client zone (different from shop) has a tax rate set it will be used which is questionable... No tax should be applied in this case.
Then, if displaying prices with tax, tax is calculated as a 'gross price'. Displayed value is like 'actual tax - tax of the tax'...
For example:
Set shop zone to Alabama and 'Basis of Product Tax' to 'Shop', then 'Display prices with Tax' to true and customer address to Florida (where 7% tax apply).
Add product 25 'Microsoft keyboard' in cart and go through checkout.
Tax will be 4.58 instead of 4.90.
Strangely, 4.58 + (4.58 * .07) = 4.90...
When 'Display prices with Tax' is set to false, then tax is 4.90. But anyway in both case there should be no tax at all
The text was updated successfully, but these errors were encountered: