Paypaldp.php INVNUM format change to fight duplicated orders #5650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update INVNUM format to fight duplicated orders/submission. Reduce the resolution for INVNUM from 1s to 60s.
|
time() function used twice in paypaldp.php. One is for INVNUM. Another is CUSTOM. Paypal only uses INVNUM to identify whether it is a duplicated order or not, so I only changed INVNUM. CUSTOM remains unchanged. paypal statement regarding INVNUM can be found here: https://www.paypal.com/us/cshelp/article/how-do-i-avoid-duplicate-transactions-ts1097 Note: I tested this mod only in zen cart 1.5.7d and it worked. Not sure if the root issue to cause duplicated orders have been fixed in 1.5.8 or 1.5.8a or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the forum:
https://www.zen-cart.com/showthread.php?229318-Advise-needed-to-change-the-format-of-INVNUM-to-fight-duplicated-orders&p=1393626
This PR is a walk around solution to reduce/fight the duplicated orders/submissions. It will reduce the resolution for INVNUM value from 1s to 60s. Paypal will auto denied the duplicated transactions with the same INVNUM number.