Payment class, correct PHP deprecation by using the correct variable #6022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing logs similar to the following due to variable-name 'misspelling': ``` [25-Oct-2023 11:38:20 America/Chicago] Request URI: /index.php?main_page=checkout_process, IP address: x.x.x.x, Language id 1 #0 /home/mystore/public_html/includes/classes/payment.php(134): zen_debug_error_handler() #1 /home/mystore/public_html/includes/modules/checkout_process.php(84): payment->checkCreditCovered() #2 /home/mystore/public_html/includes/modules/pages/checkout_process/header_php.php(13): require('/home/mystore/...') #3 /home/mystore/public_html/index.php(35): require('/home/mystore/...') --> PHP Deprecated: Creation of dynamic property payment::$selected_method is deprecated in /home/mystore/public_html/includes/classes/payment.php on line 134. ```
drbyte
pushed a commit
to drbyte/zencart
that referenced
this pull request
Jan 30, 2024
…encart#6022) Seeing logs similar to the following due to variable-name 'misspelling': ``` [25-Oct-2023 11:38:20 America/Chicago] Request URI: /index.php?main_page=checkout_process, IP address: x.x.x.x, Language id 1 #0 /home/mystore/public_html/includes/classes/payment.php(134): zen_debug_error_handler() #1 /home/mystore/public_html/includes/modules/checkout_process.php(84): payment->checkCreditCovered() zencart#2 /home/mystore/public_html/includes/modules/pages/checkout_process/header_php.php(13): require('/home/mystore/...') zencart#3 /home/mystore/public_html/index.php(35): require('/home/mystore/...') --> PHP Deprecated: Creation of dynamic property payment::$selected_method is deprecated in /home/mystore/public_html/includes/classes/payment.php on line 134. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing logs similar to the following due to variable-name 'misspelling':