Updates for strict-types

[drbyte]

Fixes #6082

[torvista]

But then in strict types mode, explode on the next line complains when it is fed an integer...I've got functions_products and the shopping cart class using strict types mode and there are ("only") half a dozen places where casting is needed to clear all the errors (when a product is added to the cart).

[drbyte]

Right.

Remember, coercive typing is one of the reasons people choose PHP over other languages like Java and C that are heavily strictly-typed.

[torvista]

While I may the only one beating ZC with this stick, there are really very few places left where ZC falls foul of this/it's nearly ready for a stricter world. Be nice to clear them.

[drbyte]

Tested with several non-attribute products, with fractional quantities. Errors not thrown.

You probably have some specific products that warrant testing this with, though.

[torvista]

Simple products give no errors.

Product with attributes:
PHP Fatal error: Uncaught TypeError: strpos(): Argument #1 ($haystack) must be of type string, int given in includes\classes\shopping_cart.php:316

zencart/includes/classes/shopping_cart.php

Line 316 in e6bce46

if (strpos($option, TEXT_PREFIX) === 0) {

[drbyte]

Thanks. I'll reset my demo data later and check this

[drbyte]

Lots more updates made.
There's a HUGE risk of introducing rounding errors due to the loss of precision that occurs when trying to implement strict-typing with numeric data when it could legitimately be an integer or a float interchangeably ... such as with fractional quantities and with taxes.
I really hope this didn't break anything.

[torvista]

In my limited testing, with the shopping_cart class, functions_products and functions_general_shared all using strict types, I could checkout with simple and attributed products with no rounding errors.

Only two simple errors:

zencart/includes/functions/functions_general_shared.php

Line 20 in e6bce46

@set_time_limit($limit);

$limit being passed as string instead of int.

zencart/includes/functions/functions_general_shared.php

Lines 191 to 197 in e6bce46

	$get_url .= rawurlencode(stripslashes($key)) . '=' . rawurlencode(stripslashes($value)) . '&';
	}
	} else {
	if (IS_ADMIN_FLAG) continue; // admin (and maybe catalog?) doesn't support passing arrays by GET, so skipping any arrays here
	foreach (array_filter($value) as $arr) {
	if (is_array($arr)) continue;
	$get_url .= rawurlencode(stripslashes($key)) . '[]=' . rawurlencode(stripslashes($arr)) . '&';

$key being passed to stripslashes as an int instead of a string

[drbyte]

$key being passed to stripslashes as an int instead of a string

This is because elsewhere (some of) those values were cast to int for other reasons.