New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade RuboCop #100
Upgrade RuboCop #100
Conversation
Remove unneccessary config
@@ -75,17 +84,14 @@ Style/FormatString: | |||
Style/GuardClause: | |||
Enabled: false | |||
|
|||
Style/HashSyntax: | |||
EnforcedStyle: ruby19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wut ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to duplicate the default configuration: https://github.com/bbatsov/rubocop/blob/v0.48.1/config/default.yml#L620-L621
Style/IfUnlessModifier: | ||
Enabled: false | ||
|
||
Style/IndentHash: | ||
EnforcedStyle: consistent | ||
|
||
Style/IndentationWidth: | ||
Width: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to duplicate the default configuration: https://github.com/bbatsov/rubocop/blob/v0.48.1/config/default.yml#L651-L653
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except for the 1.9 hash style
nice!
…On Thu, Apr 6, 2017 at 10:46 AM, Benjamin Quorning ***@***.*** > wrote:
***@***.**** commented on this pull request.
------------------------------
In .rubocop.yml
<#100 (comment)>
:
> Style/IfUnlessModifier:
Enabled: false
Style/IndentHash:
EnforcedStyle: consistent
-Style/IndentationWidth:
- Width: 2
No need to duplicate the default configuration:
https://github.com/bbatsov/rubocop/blob/v0.48.1/config/
default.yml#L651-L653
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAsZ_bktz_-Qy6m9J1aOdbpYDH8QeBBks5rtSTYgaJpZM4M1cU_>
.
|
No description provided.