Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added opportunity to set a custom icon on the menu button. #143

Closed
wants to merge 5 commits into from
Closed

Added opportunity to set a custom icon on the menu button. #143

wants to merge 5 commits into from

Conversation

Poeschl
Copy link

@Poeschl Poeschl commented Feb 27, 2015

I changed the menu class, so that you can set a own icon for the menu button. If the menu is expanded the icon transforms into a 'x' to indicate the close action.
Maybe this helps you with this issue: #56

I also added the icon function to one of the menus in the sample. Feel free to give me any feedback about this.

@thesparky007
Copy link

Will this be merged into the main branch?

@Simon-Raes
Copy link

I encountered a small bug with this code where the collapsed drawable would be invisible if I closed and re-opened a screen while the menu was in the open state.

I fixed it by adding the following code here.
layeredDrawable.getDrawable(COLLAPSED_DRAWABLE).setAlpha(MAX_ALPHA);

This resets the collapsed drawable's alpha so it is visible again when opening the screen.

@ticofab
Copy link

ticofab commented Apr 22, 2015

Any news on merging this into the main branch? Or @Poeschl are you considering making your fork available via maven / gradle ?

@Poeschl
Copy link
Author

Poeschl commented Apr 22, 2015

@ticofab I'm not intending to push it to a Maven Repository. I was hoping to get this merged. And when I have some more time I will improve it to looks like the inbox button.

@pranayairan
Copy link

Will this be merged anytime soon ?? There are lot of great additions to the library that are waiting to be merged. @chalup

@@ -35,5 +35,6 @@
<enum name="left" value="2"/>
<enum name="right" value="3"/>
</attr>
<attr name="fab_collapsedIcon" format="reference"/>>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/>>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 0148bd7

@Zakay
Copy link

Zakay commented May 26, 2015

Changing the icon was the first thing I wanted to do. This should really be merged.

@Zakay
Copy link

Zakay commented May 26, 2015

@Poeschl I found a fork of this library which is more active and has more features.
https://github.com/Clans/FloatingActionButton

It has implemented custom icon for the menu button but the icon is used for both states and is rotated when clicked. One of the weirdest solutions.

If you add your fab_collapsedIcon to this project I think the author will merge it pretty quickly as he seems very active.

@Poeschl
Copy link
Author

Poeschl commented May 26, 2015

@Zakay Whuu, thanks for that reply. If I find some time, I will do that and report here when I'm finished.

@Zakay
Copy link

Zakay commented May 26, 2015

I actually already sent a pull request!

@Poeschl
Copy link
Author

Poeschl commented May 26, 2015

Nice :)

@Poeschl
Copy link
Author

Poeschl commented Jun 23, 2015

@chalup Is there a chance to get this merged? It is laying around for nearly 30 days.

@Reckonian
Copy link

Any timeline for this getting merged to the main branch? This feature is completely dependent on me using this library.

@Poeschl Poeschl closed this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants