-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added opportunity to set a custom icon on the menu button. #143
Conversation
Will this be merged into the main branch? |
I encountered a small bug with this code where the collapsed drawable would be invisible if I closed and re-opened a screen while the menu was in the open state. I fixed it by adding the following code here. |
Update fork to latest version
Any news on merging this into the main branch? Or @Poeschl are you considering making your fork available via maven / gradle ? |
@ticofab I'm not intending to push it to a Maven Repository. I was hoping to get this merged. And when I have some more time I will improve it to looks like the inbox button. |
Will this be merged anytime soon ?? There are lot of great additions to the library that are waiting to be merged. @chalup |
@@ -35,5 +35,6 @@ | |||
<enum name="left" value="2"/> | |||
<enum name="right" value="3"/> | |||
</attr> | |||
<attr name="fab_collapsedIcon" format="reference"/>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/>>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit 0148bd7
Changing the icon was the first thing I wanted to do. This should really be merged. |
@Poeschl I found a fork of this library which is more active and has more features. It has implemented custom icon for the menu button but the icon is used for both states and is rotated when clicked. One of the weirdest solutions. If you add your fab_collapsedIcon to this project I think the author will merge it pretty quickly as he seems very active. |
@Zakay Whuu, thanks for that reply. If I find some time, I will do that and report here when I'm finished. |
I actually already sent a pull request! |
Nice :) |
@chalup Is there a chance to get this merged? It is laying around for nearly 30 days. |
Any timeline for this getting merged to the main branch? This feature is completely dependent on me using this library. |
I changed the menu class, so that you can set a own icon for the menu button. If the menu is expanded the icon transforms into a 'x' to indicate the close action.
Maybe this helps you with this issue: #56
I also added the icon function to one of the menus in the sample. Feel free to give me any feedback about this.