allow threshold argument to passes_threshold? to enable re-use in subclasses
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Dec 5, 2016
| @@ -55,7 +55,7 @@ def enabled_for?(feature_recipient) | |||
| return false if feature_recipient.nil? | |||
| return false if blacklisted?(feature_recipient) | |||
| return true if whitelisted?(feature_recipient) | |||
| passes_threshold?(feature_recipient) | |||
| passes_threshold?(feature_recipient, self.deployment_percentage || 0) | |||
grosser
reviewed
Dec 5, 2016
| @@ -81,8 +81,7 @@ def self.last_updated_at | |||
|
|
|||
| protected | |||
|
|
|||
| def passes_threshold?(feature_recipient) | |||
| threshold = self.deployment_percentage || 0 | |||
| def passes_threshold?(feature_recipient, threshold) | |||
There was a problem hiding this comment.
a test that shows this usage ... or some docs why this is here would be nice
There was a problem hiding this comment.
it's not a public interface, so a test feels inappropriate. What are you concretely asking for?
There was a problem hiding this comment.
... at least docs would be nice ... # used by external library, do not modify interface
also means we are using a protected method ... making it public might be more obvious ... but either way is fine
|
👍 |
|
👍 thanks for humoring me |
|
👍 |
|
@grosser can you release v2.2.3? I merged and tagged and everything but don't have the perms to release |
|
done, next time you can do it yourself ;)
…On Mon, Dec 5, 2016 at 5:07 PM, Ben Osheroff ***@***.***> wrote:
@grosser <https://github.com/grosser> can you release v2.2.3? I merged
and tagged and everything but don't have the perms to release
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#102 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAsZ8k0_oqp9DcQmASDmdYKGmy_mZR5ks5rFLVkgaJpZM4LE0JB>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ggrossman @grosser