Tweak naming for a couple public methods #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small wart that I instantly regretted after putting out `v1.0.0`. Use of #business_hours= is now considered deprecated and will be removed in `v2.0.0`. We'll probably put out a migration version (i.e. `v1.99`) similar to `rspec` that emits warnings for deprecated methods like this when the time comes to release the next major version.
Similar to configuring with #business_hours=, .business_hours? is deprecated and will be removed in `v2.0.0`.
|
👍 |
craiglittle
added a commit
that referenced
this pull request
Feb 26, 2015
Tweak naming for a couple public methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a couple of small warts that I instantly regretted after putting out
v1.0.0. Might as well fix it up now. The replaced methods will be considered deprecated and removed inv2.0.0.@alex-stone @kruppel