fix(article): add aria-label to user navigation

zendesk · Sep 14, 2023 · 07f4b15 · 07f4b15
1 parent c664c5f
commit 07f4b15
Show file tree

Hide file tree

Showing 11 changed files with 21 additions and 21 deletions.
diff --git a/templates/article_page.hbs b/templates/article_page.hbs
@@ -1,6 +1,6 @@
 <div class="container-divider"></div>
 <div class="container">
-  <nav class="sub-nav">
+  <div class="sub-nav">
     {{breadcrumbs}}
     <div class="search-container">
       <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" focusable="false" viewBox="0 0 12 12" class="search-icon" aria-hidden="true">
@@ -9,7 +9,7 @@
       </svg>
       {{search scoped=settings.scoped_kb_search submit=false}}
     </div>
-  </nav>
+  </div>
 
   <div class="article-container" id="article-container">
     <aside class="article-sidebar" aria-labelledby="section-articles-title">

diff --git a/templates/category_page.hbs b/templates/category_page.hbs
@@ -1,6 +1,6 @@
 <div class="container-divider"></div>
 <div class="container">
-  <nav class="sub-nav">
+  <div class="sub-nav">
     {{breadcrumbs}}
     <div class="search-container">
       <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" focusable="false" viewBox="0 0 12 12" class="search-icon" aria-hidden="true">
@@ -9,7 +9,7 @@
       </svg>
       {{search scoped=settings.scoped_kb_search submit=false}}
     </div>
-  </nav>
+  </div>
 
   <div class="category-container">
     <div class="category-content">

diff --git a/templates/community_post_list_page.hbs b/templates/community_post_list_page.hbs
@@ -12,9 +12,9 @@
 </section>
 
 <div class="container">
-  <nav class="sub-nav">
+  <div class="sub-nav">
     {{breadcrumbs}}
-  </nav>
+  </div>
 
   <header class="page-header community-header">
       <span class="dropdown">

diff --git a/templates/community_post_page.hbs b/templates/community_post_page.hbs
@@ -1,6 +1,6 @@
 <div class="container-divider"></div>
 <div class="container">
-  <nav class="sub-nav">
+  <div class="sub-nav">
     {{breadcrumbs}}
     <div class="search-container">
       <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" focusable="false" viewBox="0 0 12 12" class="search-icon" aria-hidden="true">
@@ -9,7 +9,7 @@
       </svg>
       {{search scoped=settings.scoped_community_search submit=false}}
     </div>
-  </nav>
+  </div>
 
   <div class="post-container">
     <div class="post">

diff --git a/templates/community_topic_list_page.hbs b/templates/community_topic_list_page.hbs
@@ -12,9 +12,9 @@
 </section>
 
 <div class="container">
-  <nav class="sub-nav">
+  <div class="sub-nav">
     {{breadcrumbs}}
-  </nav>
+  </div>
 
   <header class="page-header community-header">
       <span class="dropdown">

diff --git a/templates/community_topic_page.hbs b/templates/community_topic_page.hbs
@@ -1,6 +1,6 @@
 <div class="container-divider"></div>
 <div class="container">
-   <nav class="sub-nav">
+   <div class="sub-nav">
     {{breadcrumbs}}
     <div class="search-container">
       <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" focusable="false" viewBox="0 0 12 12" class="search-icon" aria-hidden="true">
@@ -9,7 +9,7 @@
       </svg>
       {{search scoped=settings.scoped_community_search submit=false}}
     </div>
-  </nav>
+  </div>
 
   <header class="page-header">
     <h1>

diff --git a/templates/header.hbs b/templates/header.hbs
@@ -11,7 +11,7 @@
   </div>
 
   <div class="nav-wrapper-desktop">
-    <nav class="user-nav" id="user-nav">
+    <nav class="user-nav" id="user-nav" aria-label="{{t 'user_navigation'}}">
       <ul class="user-nav-list">
         <li>{{link 'community'}}</li>
         <li>{{link 'new_request' class='submit-a-request'}}</li>

diff --git a/templates/new_community_post_page.hbs b/templates/new_community_post_page.hbs
@@ -1,6 +1,6 @@
 <div class="container-divider"></div>
 <div class="container">
-  <nav class="sub-nav">
+  <div class="sub-nav">
     {{breadcrumbs}}
     <div class="search-container">
       <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" focusable="false" viewBox="0 0 12 12" class="search-icon" aria-hidden="true">
@@ -9,7 +9,7 @@
       </svg>
       {{search submit=false}}
     </div>
-  </nav>
+  </div>
 
   <h1 class="form-header">
     {{t 'what_is_your_post_about'}}

diff --git a/templates/new_request_page.hbs b/templates/new_request_page.hbs
@@ -1,6 +1,6 @@
 <div class="container-divider"></div>
 <div class="container">
-  <nav class="sub-nav">
+  <div class="sub-nav">
     {{breadcrumbs}}
     <div class="search-container">
       <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" focusable="false" viewBox="0 0 12 12" class="search-icon" aria-hidden="true">
@@ -9,7 +9,7 @@
       </svg>
       {{search submit=false}}
     </div>
-  </nav>
+  </div>
 
   <h1>
     {{t 'submit_a_request'}}

diff --git a/templates/search_results.hbs b/templates/search_results.hbs
@@ -1,6 +1,6 @@
 <div class="container-divider"></div>
 <div class="container">
-  <nav class="sub-nav">
+  <div class="sub-nav">
     {{breadcrumbs}}
     <div class="search-container">
       <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" focusable="false" viewBox="0 0 12 12" class="search-icon" aria-hidden="true">
@@ -9,7 +9,7 @@
       </svg>
       {{search submit=false}}
     </div>
-  </nav>
+  </div>
 
   <div class="search-results">
     <aside class="search-results-sidebar">

diff --git a/templates/section_page.hbs b/templates/section_page.hbs
@@ -1,6 +1,6 @@
 <div class="container-divider"></div>
 <div class="container">
-  <nav class="sub-nav">
+  <div class="sub-nav">
     {{breadcrumbs}}
     <div class="search-container">
       <svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" focusable="false" viewBox="0 0 12 12" class="search-icon" aria-hidden="true">
@@ -9,7 +9,7 @@
       </svg>
       {{search scoped=settings.scoped_kb_search submit=false}}
     </div>
-  </nav>
+  </div>
 
   <div class="section-container">
     <section id="main-content" class="section-content">