fix: update breadcrumbs aria-label to use translated strings

zendesk · Jun 7, 2023 · c75f24d · c75f24d
1 parent 72279b9
commit c75f24d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/templates/search_results.hbs b/templates/search_results.hbs
@@ -216,7 +216,11 @@
                     </div>
                   </div>
                   <div class="search-result-meta-container">
-                    <nav aria-label="Search result location">
+                    <nav 
+                      {{#is type 'article'}}aria-label='{{t 'article_location_with_title' title=title}}'{{/is}}
+                      {{#is type 'community_post'}}aria-label='{{t 'post_location_with_title' title=title}}'{{/is}}
+                      {{#is type 'external_content_record'}}aria-label='{{t 'external_content_location_with_title' title=title}}'{{/is}}
+                    >
                       <ol class="breadcrumbs search-result-breadcrumbs">
                         {{#each path_steps}}
                           <li><a href="{{url}}" target="{{target}}">{{name}}</a></li>

diff --git a/templates/user_profile_page.hbs b/templates/user_profile_page.hbs
@@ -195,8 +195,11 @@
                           <span class="status-label status-label-official">{{t 'official_comment'}}</span>
                         {{/if}}
                       </header>
-
-                      <nav aria-label="Activity location">
+                      <nav
+                        {{#is object_type 'article'}}aria-label='{{t 'article_location_with_title' title=title}}'{{/is}}
+                        {{#is object_type 'post'}}aria-label='{{t 'post_location_with_title' title=title}}'{{/is}}
+                        {{#is object_type 'comment'}}aria-label='{{t 'comment_location_with_author_name' author_name=author.name}}'{{/is}}
+                      >
                         <ol class="breadcrumbs profile-contribution-breadcrumbs">
                           {{#each path_steps}}
                             <li><a href="{{url}}">{{name}}</a></li>
@@ -358,8 +361,11 @@
                         <span class="status-label status-label-official">{{t 'official_comment'}}</span>
                       {{/if}}
                     </header>
-
-                    <nav aria-label="Contribution location">
+                    <nav
+                      {{#is object_type 'article'}}aria-label='{{t 'article_location_with_title' title=title}}'{{/is}}
+                      {{#is object_type 'post'}}aria-label='{{t 'post_location_with_title' title=title}}'{{/is}}
+                      {{#is object_type 'comment'}}aria-label='{{t 'comment_location_with_author_name' author_name=author.name}}'{{/is}}
+                    >
                       <ol class="breadcrumbs profile-contribution-breadcrumbs">
                         {{#each path_steps}}
                           <li><a href="{{url}}">{{name}}</a></li>