fix: add aria-label to the '+ N more badges' links

zendesk · Mar 2, 2022 · e478a82 · e478a82
1 parent 74cdcfc
commit e478a82
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/templates/article_page.hbs b/templates/article_page.hbs
@@ -250,7 +250,9 @@
 
                             {{#if (compare (calc author.badges.length "-" 4) ">" 0)}}
                               <div class="community-badge community-badge-achievements">
-                                {{#link "user_profile" id=author.id filter_by="badges" class="community-badge-achievements-rest"}}{{t 'plus_more' count=(calc author.badges.length "-" 4)}}{{/link}}
+                                <a href="{{page_path "user_profile" id=author.id filter_by="badges"}}" class="community-badge-achievements-rest"  aria-label="{{t 'more_awards_to' count=(calc author.badges.length "-" 4) name=author.name}}">
+                                  {{t 'plus_more' count=(calc author.badges.length "-" 4)}}
+                                </a>
                               </div>
                             {{/if}}
                           </div>

diff --git a/templates/community_post_page.hbs b/templates/community_post_page.hbs
@@ -99,7 +99,9 @@
 
                   {{#if (compare (calc post.author.badges.length "-" 4) ">" 0)}}
                     <div class="community-badge community-badge-achievements">
-                      {{#link "user_profile" id=post.author.id filter_by="badges" class="community-badge-achievements-rest"}}{{t 'plus_more' count=(calc post.author.badges.length "-" 4)}}{{/link}}
+                      <a href="{{page_path "user_profile" id=post.author.id filter_by="badges"}}" class="community-badge-achievements-rest"  aria-label="{{t 'more_awards_to' count=(calc post.author.badges.length "-" 4) name=post.author.name}}">
+                        {{t 'plus_more' count=(calc post.author.badges.length "-" 4)}}
+                      </a>
                     </div>
                   {{/if}}
 
@@ -250,7 +252,9 @@
 
                       {{#if (compare (calc author.badges.length "-" 4) ">" 0)}}
                         <div class="community-badge community-badge-achievements">
-                          {{#link "user_profile" id=author.id filter_by="badges" class="community-badge-achievements-rest"}}{{t 'plus_more' count=(calc author.badges.length "-" 4)}}{{/link}}
+                          <a href="{{page_path "user_profile" id=author.id filter_by="badges"}}" class="community-badge-achievements-rest"  aria-label="{{t 'more_awards_to' count=(calc author.badges.length "-" 4) name=author.name}}">
+                            {{t 'plus_more' count=(calc author.badges.length "-" 4)}}
+                          </a>
                         </div>
                       {{/if}}
                     </div>

diff --git a/templates/user_profile_page.hbs b/templates/user_profile_page.hbs
@@ -46,7 +46,9 @@
 
           {{#if (compare (calc user.badges.length "-" 4) ">" 0)}}
             <div class="community-badge community-badge-achievements">
-              {{#link "user_profile" id=user.id filter_by="badges" class="community-badge-achievements-rest"}}{{t 'plus_more' count=(calc user.badges.length "-" 4)}}{{/link}}
+              <a href="{{page_path "user_profile" id=user.id filter_by="badges"}}" class="community-badge-achievements-rest" aria-label="{{t 'more_awards_to' count=(calc user.badges.length "-" 4) name=user.name}}">
+                {{t 'plus_more' count=(calc user.badges.length "-" 4)}}
+              </a>
             </div>
           {{/if}}
         </div>