Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Refresh() function creates new AwsEc2Provider each time it is
executed. Morover it sets AwsConfig field to an "empty" aws.Config{}
causing aws.Config.Region to be . This forces REGION to be taken
from ~/.aws/config profile instead of .goship.yaml config file.
It could be fixed by:
"AwsConfig: config" -> "AwsConfig: g.Provider.AwsConfig":
or (imo) even better to simply reuse existing provider without creating
a new struct. And that's what I'm suggesting in this commit.