Revert "[CCORE-371] Fall back to database on 'multi_response has completed' RuntimeError" #69

mervync · 2022-03-07T23:24:33Z

Reverts [CCORE-371] Fall back to database on 'multi_response has completed' RuntimeError #66
This did not properly fix the issue anyway as the next request using the dalli client would end up with a corrupt response and fail.
The proper fix was added in Raise NetworkError and reconnect when multi_response_nonblock is unexpectedly called petergoldstein/dalli#783
The error also seems to have gone away so maybe Elasticache fixed the issue...?

…meError" This reverts commit 0ccf0a7.

cryptomail

I'm very sad about the failed response and serialization
But I'm happy all these problems were mitigated by other sources and fixes.

mervync force-pushed the revert-66-mervyn/CCORE-371_handle_multi_get_error branch from b056ae3 to a5c152a Compare March 16, 2022 17:15

mervync marked this pull request as ready for review March 16, 2022 17:16

mervync requested a review from a team as a code owner March 16, 2022 17:16

mervync added 2 commits March 16, 2022 10:19

Revert "Fall back to database on 'multi_response has completed' Runti…

c4c36fd

…meError" This reverts commit 0ccf0a7.

Remove CircleCI build status from README

547cbc7

mervync force-pushed the revert-66-mervyn/CCORE-371_handle_multi_get_error branch from a5c152a to 547cbc7 Compare March 16, 2022 17:19

cryptomail approved these changes Mar 16, 2022

View reviewed changes

mervync merged commit 5d7792e into master Mar 22, 2022

mervync deleted the revert-66-mervyn/CCORE-371_handle_multi_get_error branch March 22, 2022 19:02

Provide feedback