Merge pull request #26 from zendesk/sbloch/consider-namespace-in-key-…

…length Consider presence of namespace when computing slice size
zendesk · Jan 25, 2024 · 9e85d26 · 9e85d26
2 parents c3bf721 + b3fa2ad
commit 9e85d26
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    large_object_store (1.6.0)
+    large_object_store (1.6.1)
       zstd-ruby (~> 1.5.5)
 
 GEM

diff --git a/lib/large_object_store.rb b/lib/large_object_store.rb
@@ -38,7 +38,9 @@ def write(key, value, **options)
 
       # calculate slice size; note that key length is a factor because
       # the key is stored on the same slab page as the value
-      slice_size = MAX_OBJECT_SIZE - ITEM_HEADER_SIZE - UUID_SIZE - key.bytesize
+      namespace = (store.respond_to?(:options) && store.options[:namespace]) || ""
+      namespace_length = namespace.empty? ? 0 : namespace.size + 1
+      slice_size = MAX_OBJECT_SIZE - ITEM_HEADER_SIZE - UUID_SIZE - key.bytesize - namespace_length
 
       # store number of pages
       pages = (value.size / slice_size.to_f).ceil

diff --git a/lib/large_object_store/version.rb b/lib/large_object_store/version.rb
@@ -1,3 +1,3 @@
 module LargeObjectStore
-  VERSION = "1.6.0"
+  VERSION = "1.6.1"
 end