issue 376 -- parse and ignore RENAME INDEX statements #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -200,7 +200,8 @@ public void testParsingSomeAlters() { | |||
| "create table `shard1.foo` ( `id.foo` int ) collate = `utf8_bin`", | |||
| "ALTER TABLE .`users` CHANGE COLUMN `password` `password` VARCHAR(60) CHARACTER SET 'utf8' COLLATE 'utf8_bin' NULL DEFAULT NULL COMMENT 'Length 60 for Bcrypt'", | |||
| "create table `shard1.foo` ( `id.foo` int ) collate = `utf8_bin`", | |||
| "create table if not exists audit_payer_bank_details (event_time TIMESTAMP default CURRENT_TIMESTAMP())" | |||
| "create table if not exists audit_payer_bank_details (event_time TIMESTAMP default CURRENT_TIMESTAMP())", | |||
| "ALTER TABLE foo RENAME INDEX index_quote_request_follow_on_data_on_model_name TO index_quote_request_follow_on_data_on_model_class_name" | |||
There was a problem hiding this comment.
oh so this is possible b/c it is just parsing testing, not being executed against mysql 5.5 and 5.6
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#376
@zendesk/rules