fix misc bugs #68
fix misc bugs #68
Conversation
these two are SQL-syntax-only aliases for a TINYINT(1) column
these are sql-syntax aliases for 'double' types
| @@ -35,6 +35,8 @@ | |||
| SQL_BLACKLIST.add(Pattern.compile("^ANALYZE\\s+TABLE", Pattern.CASE_INSENSITIVE)); | |||
| SQL_BLACKLIST.add(Pattern.compile("^SET\\s+PASSWORD", Pattern.CASE_INSENSITIVE)); | |||
| SQL_BLACKLIST.add(Pattern.compile("^(CREATE|DROP|RENAME)\\s+USER", Pattern.CASE_INSENSITIVE)); | |||
|
|
|||
| SQL_BLACKLIST.add(Pattern.compile("^TRUNCATE\\s+TABLE", Pattern.CASE_INSENSITIVE)); | |||
There was a problem hiding this comment.
Suggest we add this to a Caveat section, and explain our limitation there.
There was a problem hiding this comment.
Need another rule to catch truncate of partitions similar to:
SQL_BLACKLIST.add(Pattern.compile("^ALTER\\sTABLE.*TRUNCATE"));
For SQL such as ALTER TABLE foo TRUNCATE PARTITION p4;
There was a problem hiding this comment.
sorry for the lag @rhamnett. Yeah, maxwell needs to be able to parse PARTITION stuff in general. It's currently simply not supported, and is one of the last cleanups left in the sql parser section.
|
👍 |
| @Test | ||
| public void testYearWithLength() throws Exception { | ||
| String sql[] = { | ||
| "create TABLE `test_year` ( id year(4) )" |
There was a problem hiding this comment.
Wondering what made them create a YEAR type. What do they do for BC years? negative? Are there no paleontologist+DBAs?
|
I was just wondering if there is going to be support for GTID instead of On Thu, Jun 18, 2015 at 2:59 PM, Ben Osheroff notifications@github.com
|
|
GTID: yeah, at some point, but it's not on any short-term roadmap. it'll be quite a bit of work down in open-replicator. |
address #64, #65, #66, #67
@vanchi-zendesk @akshayi1