Clean up consumer config #290
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonmaia
force-pushed
the
lmaia/consumer-config
branch
from
639b2e4
to
084e79b
Compare
leonmaia
force-pushed
the
lmaia/consumer-config
branch
from
084e79b
to
49d7e37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes consumer configuration naming. Some consumer configurations as
max_bytes_per_partitionandmax_byteswere not standardised to use matching names with https://github.com/edenhill/librdkafka configurations and instead were still using what we used with https://github.com/zendesk/ruby-kafka.This creates confusion when trying to understand configurations and what are the defaults in Racecar and https://github.com/edenhill/librdkafka.