Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rdkafka ~> 0.15; require Ruby 3.0 since 2.6 is EOL #366

Merged
merged 1 commit into from Mar 15, 2024

Conversation

tednology
Copy link
Contributor

@tednology tednology commented Mar 5, 2024

What

This PR completes a couple of housekeeping items:

  1. Set required Ruby to >= 3.0 in the Gemspec (2.6 is EOL, 2.7 support dropping in rdkafka-ruby soon, too)
  2. Upgrade rdkafka to ~> 0.15.0

I noticed that rdkafka 0.15.0 minimum Ruby is 2.7 anyway.

@mensfeld
Copy link

mensfeld commented Mar 8, 2024

@tednology you might as well directly go to 3.0 because I am dropping support for 2.7 soon: karafka/rdkafka-ruby#374

@tednology tednology changed the title Upgrade rdkafka ~> 0.15; require Ruby 2.7 since 2.6 is EOL Upgrade rdkafka ~> 0.15; require Ruby 3.0 since 2.6 is EOL Mar 12, 2024
@tednology
Copy link
Contributor Author

@mensfeld Done.

@mensfeld
Copy link

No need to ping me. It's not my framework and I don't have merge permissions here ;) it was just a friendly advise from rdkafka maintainer.

@tednology
Copy link
Contributor Author

Hah, well, thanks anyway 😄.

@deepredsky or @dasch, sorry for the ping, would it be possible to review this small upgrade? We don't need the minimum Ruby version requirement @ 3.0 (2.7 will suffice) if it's a concern.

@deepredsky
Copy link
Collaborator

@tednology thanks for this pull request. I need to double check that upgrading rdkafka will not require any additional changes. +1 to dropping 2.6 support

@mensfeld
Copy link

@deepredsky it will not. 0.15.0 is fully backwards compatible with 0.13 though I did change several timeouts to higher values.

Copy link
Collaborator

@deepredsky deepredsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tednology can u add a changelog entry and also fixup the commit about lockfile. I will release a new beta with this tomorrow

@tednology
Copy link
Contributor Author

You bet!

@deepredsky deepredsky merged commit 5200577 into zendesk:master Mar 15, 2024
5 checks passed
@jandudulski
Copy link

jandudulski commented Mar 26, 2024

@deepredsky can you please release a new beta with this change? 🙏

@deepredsky
Copy link
Collaborator

@deepredsky can you please release a new beta with this change? 🙏

hi @jandudulski new beta is released. Also wanted to mention that you don't have to wait for beta versions to be released to use in ur project, you can use bundler's git feature to test the unreleased changes :)

@jandudulski
Copy link

Thank you @deepredsky . Unfortunately, I have to bump it in another lib that is built on top of racecar, and this makes things a little bit more complicated to test 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants