Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing npm line to example_2/SETUP.txt #114

Merged
merged 3 commits into from Nov 27, 2014

Conversation

bolddane
Copy link
Contributor

Add missing npm line to example_2/SETUP.txt.

/cc @zendesk/zendesk-radar

Steps to merge

  • 馃憤 of the team

References

  • Jira link: none

Risks

  • None: no changes made to the radar codebase; just an addition of examples code

@vanchi-zendesk
Copy link
Contributor

+1 Yes, I was wondering how this was exposed. Didn't realize the examples are only on gh-pages.

@bolddane
Copy link
Contributor Author

@vanchi-zendesk Are you suggesting that I should also create an examples directory in the master radar branch, and refer to it from the README.md here: https://github.com/zendesk/radar#documentation ?

I did briefly consider doing this, but then thought that having a sample directory and an examples directory might create more confusion than clarity. In the documentation link and anchor above, we do point to the to tutorial early.

I have no problem duplicating the examples code in both branches, if you think that will be helpful.

@vanchi-zendesk
Copy link
Contributor

No, this is fine. As long as there is a way to get at it :-D

bolddane added a commit that referenced this pull request Nov 27, 2014
Add missing npm line to example_2/SETUP.txt
@bolddane bolddane merged commit aef1b7f into gh-pages Nov 27, 2014
@bolddane bolddane deleted the pobrien/gh_pages_examples_fix_1 branch December 1, 2014 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants