Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup package.json #200

Merged
merged 1 commit into from Jan 11, 2016
Merged

Cleanup package.json #200

merged 1 commit into from Jan 11, 2016

Conversation

junosuarez
Copy link
Contributor

  • Adds SPDX license code for apache-2.0 license
  • Sets Zendesk, Inc. as the author (move mixu to contributors list)
  • Adds some keywords because SEO like it's 1998

Required

  • 馃憤 from @zendesk/radar

Risks

  • none

],
"main": "index.js",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed, is primary entry point different?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jden for answering offline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem! for documentation's sake:

"main" in package.json sets the default package entry point, e.g. when other packages require('radar'). The default is index.js, so this change removes the redundant explicit declaration.

@kazraza
Copy link

kazraza commented Jan 11, 2016

馃憤

junosuarez added a commit that referenced this pull request Jan 11, 2016
@junosuarez junosuarez merged commit 8ec5d5f into master Jan 11, 2016
@junosuarez junosuarez deleted the jden/cleanup_package_json branch January 11, 2016 23:05
@junosuarez junosuarez mentioned this pull request Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants