Merge pull request #825 from ElenaHenderson/remove-hard-codes-sleep-c…

…onsumer-fetch-batches Issue 823 > Use max_wait_time while sleeping in fetch_batches
zendesk · May 5, 2020 · 703bf80 · 703bf80
2 parents 8660d05 + 9ed5ecc
commit 703bf80
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/kafka/consumer.rb b/lib/kafka/consumer.rb
@@ -546,7 +546,7 @@ def fetch_batches
 
       if !@fetcher.data?
         @logger.debug "No batches to process"
-        sleep 2
+        sleep(@fetcher.max_wait_time || 2)
         []
       else
         tag, message = @fetcher.poll

diff --git a/lib/kafka/fetcher.rb b/lib/kafka/fetcher.rb
@@ -4,7 +4,7 @@
 
 module Kafka
   class Fetcher
-    attr_reader :queue
+    attr_reader :queue, :max_wait_time
 
     def initialize(cluster:, logger:, instrumenter:, max_queue_size:, group:)
       @cluster = cluster