Allow passing in the seed brokers in a positional argument #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a required argument, and it's pretty central to the concept, so passing it as a positional argument makes sense.
mensfeld
reviewed
Feb 6, 2018
| if seed_brokers.nil? | ||
| Client.new(**options) | ||
| else | ||
| Client.new(seed_brokers: seed_brokers, **options) |
There was a problem hiding this comment.
question for the future: will both of them be supported or will the non positional be deprecated?
There was a problem hiding this comment.
In the future, major release, the non-positional one will probably be deprecated and removed. I'll give it at least 6-9 months first, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a required argument, and it's pretty central to the concept, so passing it as a positional argument makes sense.