Consider rebalance_timeout on join request #943
Closed
+16
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abicky
force-pushed
the
consider-rebalance-timeout
branch
from
95e8b67
to
b76b685
Compare
abicky
force-pushed
the
consider-rebalance-timeout
branch
from
b76b685
to
135b10a
Compare
This commit resolves zendesk#941. As the coordinator waits for each member to rejoin when rebalancing the group, the timeout of join request should be greater than rebalance_timeout. Otherwise, each member might send join requests over and over, and as a result, the following problems occur: * Some partitions are never processed until session_timeout passes * It takes much time for rebalance that occurs in a short time to finish
abicky
force-pushed
the
consider-rebalance-timeout
branch
from
135b10a
to
310b483
Compare
|
I'll close this PR because this PR will never seem to be merged cf. a5491ac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #941.
As the coordinator waits for each member to rejoin when rebalancing the group, the timeout of join request should be greater than rebalance_timeout.
cf. https://kafka.apache.org/protocol.html#The_Messages_JoinGroup
Otherwise, each member might send join requests over and over, and as a result, the following problems occur: