Merge pull request #4060 from zendesk/grosser/rep

podtemplate: allow setting 0 replicas
zendesk · May 18, 2023 · 0bba9e9 · 0bba9e9
2 parents 4721ab5 + c291740
commit 0bba9e9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/plugins/kubernetes/app/models/kubernetes/template_filler.rb b/plugins/kubernetes/app/models/kubernetes/template_filler.rb
@@ -46,6 +46,8 @@ def to_hash(verification: false)
           set_name
           if ['Deployment', 'StatefulSet'].include?(kind)
             set_replica_target
+          elsif kind == "PodTemplate"
+            # do nothing: the template has resources so setting to 0 is nice to make them not count in the math
           else
             validate_replica_target_is_supported
           end

diff --git a/plugins/kubernetes/test/models/kubernetes/template_filler_test.rb b/plugins/kubernetes/test/models/kubernetes/template_filler_test.rb
@@ -823,12 +823,18 @@ def secret_annotations(hash)
       end
 
       it "does not populate spec attribute" do
-        result.fetch(:spec, nil).must_be_nil
+        refute result.key? :spec
       end
 
       it "overrides image" do
         container.fetch(:image).must_equal image
       end
+
+      it "allows 0 replicas" do
+        doc.replica_target = 0
+        result
+        refute result.key? :spec
+      end
     end
 
     describe "pod" do