PAAS-286 mark pod as unscheduleable when it has abnormal events #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
commented
Sep 23, 2016
| def show_failure_cause(release) | ||
| bad_pods(release).each do |pod, client, deploy_group| | ||
| def show_failure_cause(release, release_docs) | ||
| pod_statuses(release, release_docs).reject(&:live).select(&:pod).each do |status| |
There was a problem hiding this comment.
previously this was duplicating the logic from release_statuses
grosser
commented
Sep 23, 2016
| unless successful | ||
| show_failure_cause(release) | ||
| rollback(deploys) | ||
| show_failure_cause(release, release_docs) |
There was a problem hiding this comment.
previously this showed all failed deploys ... which was never a real issue since if something failed the previous deploy would have failed ... , but this should be more correct
|
|
grosser
force-pushed
the
grosser/failures
branch
from
b925782
to
ffeab78
Compare
jonmoter
approved these changes
Oct 4, 2016
| @@ -48,6 +50,27 @@ def containers | |||
| @pod.spec.containers | |||
| end | |||
|
|
|||
| def logs(container) | |||
| client.get_pod_log(name, namespace, previous: restarted?, container: container) | |||
There was a problem hiding this comment.
This would crash if you tried calling this without first calling client=, right? If you have methods that expect there to be a valid client object, you should probably add it as a parameter to the constructor.
| def stopped? | ||
| if @stopped | ||
| @output.puts "STOPPED" | ||
| true | ||
| end | ||
| end | ||
|
|
||
| # TODO: cleanup ... a bit ugly with all these arrays |
There was a problem hiding this comment.
If you have 4-tuples of values, we should probably just create an object to encapsulate the data.
grosser
force-pushed
the
grosser/failures
branch
from
ffeab78
to
0b4cfe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonmoter @irwaters