rename confirm to more meaningful review before deploying

[grosser]

@zendesk/samson

"Confirm" sounds like useless overhead ... "Review" is closer to what it is used for ... also making the column name more descriptive ... sounds good ?

[irwaters]

I think this is probably fine either way. 'Confirm' makes me think "do you really wana press this button?" (world might end, cat's and dogs living together, mass hysteria!). 'Review' is more to check it over again, as the decision has already been made to do it...

If nobody has any objections, then I say go for it.

👍

[grosser]

I liked "Review" more since the page is the "Review" page where you can see
what you deploy

On Thu, Sep 29, 2016 at 2:09 PM, ian waters notifications@github.com
wrote:

@irwaters approved this pull request.

I think this is probably fine either way. 'Confirm' makes me think "do you
really wana press this button?" (world might end, cat's and dogs living
together, mass hysteria!). 'Review' is more to check it over again, as the
decision has already been made to do it...

If nobody has any objections, then I say go for it.

👍

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1324 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAsZ7Q3tExgavjBJ8ZhXbR8yo6hPmnvks5qvCkQgaJpZM4KKP1t
.

[grosser]

hmm I guess what the page is doing is "Preview" ... since it's not already done ... but that sounds strange too ... maybe I'll just make the column ...