Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test and fix pipelines #1740

Merged
merged 1 commit into from Feb 7, 2017
Merged

test and fix pipelines #1740

merged 1 commit into from Feb 7, 2017

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Feb 7, 2017 •
edited

lots of little inconsistencies / weirdnesses / bugs ...

  • general errors can bubble up, they will get send to aribrake
  • always set the buddy, so we know who to reach out to
  • make wording symmertrical
  • simpler argument naming
  • nicer display of multiple errors
  • reduce number of code paths
  • always test output ... previous tests crash with NoMethodError without showing it

@grosser grosser requested a review from henders February 7, 2017 16:28
henders
henders approved these changes Feb 7, 2017
View reviewed changes
Copy link
Contributor

@henders henders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grosser grosser merged commit 50fdcb5 into master Feb 7, 2017
@grosser grosser deleted the grosser/pipe branch February 7, 2017 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henders henders henders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grosser @henders