Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make slow or hanging tests blow up #247

Merged
merged 1 commit into from Feb 25, 2015
Merged

make slow or hanging tests blow up #247

merged 1 commit into from Feb 25, 2015

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Feb 24, 2015

@steved555 @pswadi-zendesk @jonmoter

..........E...

Finished in 1.578309s, 8.8703 runs/s, 15.2061 assertions/s.

  1) Error:
ApplicationHelper::#breadcrumb#test_0001_renders strings:
Timeout::Error: execution expired
    test/helpers/application_helper_test.rb:91:in `sleep'
    test/helpers/application_helper_test.rb:91:in `block (3 levels) in <main>'
    test/support/timeout.rb:12:in `block in capture_exceptions'
    test/support/timeout.rb:11:in `capture_exceptions'

Risks

  • None

@grosser grosser force-pushed the grosser/timeout branch 2 times, most recently from d62e6d4 to fe56953 Compare February 24, 2015 15:59
@jonmoter
Copy link
Collaborator

Seems safe to me. 👍

grosser added a commit that referenced this pull request Feb 25, 2015
@grosser
Merge pull request #247 from zendesk/grosser/timeout
e59403c 
make slow or hanging tests blow up
@grosser grosser merged commit e59403c into master Feb 25, 2015
@grosser grosser deleted the grosser/timeout branch February 25, 2015 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grosser @jonmoter