Gitlab support #351
Gitlab support #351
Conversation
| @@ -72,6 +72,18 @@ def repository_homepage | |||
| "//#{Rails.application.config.samson.github.web_url}/#{github_repo}" | |||
| end | |||
|
|
|||
| def repository_homepage_gitlab | |||
| "//#{ENV['GITLAB_URL']}/#{github_repo}" | |||
There was a problem hiding this comment.
Would be better if github_repo was only used for Github or rename it to a more generic name. Also, mind putting the gitlab url as a config var like this?
|
Thanks for the comments, it was just a quick PR before I went to bed. I'll make those changes tomorrow. I'll also see if I can fix the build :) |
|
Thanks @deanperry looking good! FYI, many specs are failing because the envar isn't set so we are doing |
|
Ah I see. When logged in with GitHub is there a way to import all repos? If On Wednesday, April 15, 2015, Roman Sandler notifications@github.com
Sent from Gmail Mobile |
|
Github provides this API but the feature doesn't exist in Samson yet. We find that many of our projects don't need a specific deployment step (for example api clients). |
| @@ -0,0 +1,3 @@ | |||
| <%= link_to project.repository_homepage_gitlab, class: "github", target: "_blank", title: "View repository on Gitlab" do %> | |||
| <%= image_tag "gitlab.png", width: 21, height: 21 %> | |||
| <% end %> | |||
|
I've pushed some fixes |
|
@deanperry would you mind rebasing? |
|
is it ready to be merged? |
|
I believe it is |
|
@deanperry this has merge conflicts due to changes that have been made in our master branch. We would very much like to merge your contribution but you'll need to get the latest master and do a |
|
It would be nice to get this in there, we use gitlab as well! |
|
We also use Gitlab, so this would be definitively cool! |
|
We use GitLab as well. I have rebased @deanperry's work in my fork and I am making sure everything works. Should we add/modify some tests for this feature @sandlerr? |
|
@cmckni3 yes, we'll need to make some changes that aren't yet reflected in master...cmckni3:gitlab-support - please put up a new pull request for this discussion. |
|
Ok I'm closing this for #523 |
Hey, I've just found Samson and it looks great!
I use a self hosted version of Gitlab for my projects so I've added support for Gitlab OAuth and showing Gitlab links instead of Github on the project pages.